Fix timing issues with connect failure to non 3.1.1 server

src/MQTTClient.c

@@ -489,12 +489,28 @@ thread_return_type WINAPI MQTTClient_run(void* n)
 			continue;
 		}
 		if (rc == SOCKET_ERROR)
+		{
+			if (m->c->connected)
 			{
 				Thread_unlock_mutex(mqttclient_mutex);
 				MQTTClient_disconnect_internal(m, 0);
 				Thread_lock_mutex(mqttclient_mutex);
 			}
 			else 
+			{
+				if (m->c->connect_state == 2 && !Thread_check_sem(m->connect_sem))
+				{
+					Log(TRACE_MIN, -1, "Posting connect semaphore for client %s", m->c->clientID);
+					Thread_post_sem(m->connect_sem);
+				}
+				if (m->c->connect_state == 3 && !Thread_check_sem(m->connack_sem))
+				{
+					Log(TRACE_MIN, -1, "Posting connack semaphore for client %s", m->c->clientID);
+					Thread_post_sem(m->connack_sem);
+				}
+			}
+		}
+		else
 		{
 			if (m->c->messageQueue->count > 0)
 			{
@@ -521,7 +537,7 @@ thread_return_type WINAPI MQTTClient_run(void* n)
 			}
 			if (pack)
 			{
-				if (pack->header.bits.type == CONNACK)
+				if (pack->header.bits.type == CONNACK && !Thread_check_sem(m->connack_sem))
 				{
 					Log(TRACE_MIN, -1, "Posting connack semaphore for client %s", m->c->clientID);
 					m->pack = pack;
@@ -1111,15 +1127,14 @@ int MQTTClient_disconnect1(MQTTClient handle, int timeout, int internal, int sto
 
 	MQTTClient_closeSession(m->c);
 
-	if (Thread_check_sem(m->connect_sem))
-		Thread_post_sem(m->connect_sem);
-	if (Thread_check_sem(m->connack_sem))
-		Thread_post_sem(m->connect_sem);
-	if (Thread_check_sem(m->suback_sem))
-		Thread_post_sem(m->suback_sem);
-	if (Thread_check_sem(m->unsuback_sem))
-		Thread_post_sem(m->unsuback_sem);
-
+	while (Thread_check_sem(m->connect_sem))
+		Thread_wait_sem(m->connect_sem, 100);
+	while (Thread_check_sem(m->connack_sem))
+		Thread_wait_sem(m->connack_sem, 100);
+	while (Thread_check_sem(m->suback_sem))
+		Thread_wait_sem(m->suback_sem, 100);
+	while (Thread_check_sem(m->unsuback_sem))
+		Thread_wait_sem(m->unsuback_sem, 100);
 exit:
 	if (stop)
 		MQTTClient_stop();
@@ -1582,6 +1597,8 @@ MQTTPacket* MQTTClient_waitfor(MQTTClient handle, int packet_type, int* rc, long
 			pack = MQTTClient_cycle(&sock, 100L, rc);
 			if (sock == m->c->net.socket)
 			{
+				if (*rc == SOCKET_ERROR)
+					break;
 				if (pack && (pack->header.bits.type == packet_type))
 					break;
 				if (m->c->connect_state == 1)