Incorrect free in FreeCommand1

Bug: 444934

CONTRIBUTING.md

@@ -9,7 +9,8 @@ Project description:
 The Paho project has been created to provide scalable open-source implementations of open and standard messaging protocols aimed at new, existing, and emerging applications for Machine-to-Machine (M2M) and Internet of Things (IoT).
 Paho reflects the inherent physical and cost constraints of device connectivity. Its objectives include effective levels of decoupling between devices and applications, designed to keep markets open and encourage the rapid growth of scalable Web and Enterprise middleware and applications. Paho is being kicked off with MQTT publish/subscribe client implementations for use on embedded platforms, along with corresponding server support as determined by the community.
 
-- https://projects.eclipse.org/projects/technology.paho
+- [Project web site](https://www.eclipse.org/paho)
+- [Project information](https://projects.eclipse.org/projects/iot.paho)
 
 Source
 ------
@@ -19,9 +20,7 @@ The Paho C client is stored in a git repository. The URLs to access it are:
 ssh://<username>@git.eclipse.org:29418/paho/org.eclipse.paho.mqtt.c
 https://<username>@git.eclipse.org/r/paho/org.eclipse.paho.mqtt.c
 
-A web browsable repository is available at
-
-http://git.eclipse.org/c/paho/org.eclipse.paho.mqtt.c.git
+A [web browsable repository](http://git.eclipse.org/c/paho/org.eclipse.paho.mqtt.c.git) is available.
 
 Contributing a patch
 --------------------
@@ -32,14 +31,14 @@ changes and push them back for review and eventual acceptance into the project.
 
 To do this, you must follow a few steps. The first of these are described at
 
-- https://wiki.eclipse.org/Development_Resources/Contributing_via_Git
+- [Contributing via git](https://wiki.eclipse.org/Development_Resources/Contributing_via_Git)
 
 * Sign the Eclipse CLA
 * Use a valid commit record, including a signed-off-by entry.
 
 There are further details at
 
-- https://wiki.eclipse.org/Development_Resources/Handling_Git_Contributions
+- [Handling Git Contributions](https://wiki.eclipse.org/Development_Resources/Handling_Git_Contributions)
 
 Once the patch is pushed back to Gerrit, the project committers will be
 informed and they will undertake a review of the code. The patch may need
@@ -53,41 +52,36 @@ change.
 What happens next depends on the content of the patch. If it is 100% authored
 by the contributor and is less than 1000 lines (and meets the needs of the
 project), then it can be committed to the main repository. If not, more steps
-are required. These are detailed in the legal process poster:
+are required. These are detailed in the 
+[legal process poster](http://www.eclipse.org/legal/EclipseLegalProcessPoster.pdf).
 
-- http://www.eclipse.org/legal/EclipseLegalProcessPoster.pdf
 
 Developer resources:
 --------------------
 
 Information regarding source code management, builds, coding standards, and more.
 
-- https://projects.eclipse.org/projects/technology.paho/developer
+- [https://projects.eclipse.org/projects/iot.paho/developer](https://projects.eclipse.org/projects/iot.paho/developer)
 
 Contributor License Agreement:
 ------------------------------
 
-Before your contribution can be accepted by the project, you need to create and electronically sign the Eclipse Foundation Contributor License Agreement (CLA).
-
-- http://www.eclipse.org/legal/CLA.php
+Before your contribution can be accepted by the project, you need to create and electronically sign the Eclipse Foundation [Contributor License Agreement (CLA)](http://www.eclipse.org/legal/CLA.php).
 
 Contact:
 --------
 
-Contact the project developers via the project's "dev" list.
-
-- https://dev.eclipse.org/mailman/listinfo/paho-dev
+Contact the project developers via the project's development 
+[mailing list](https://dev.eclipse.org/mailman/listinfo/paho-dev).
 
 Search for bugs:
 ----------------
 
-This project uses Bugzilla to track ongoing development and issues.
-
-- https://bugs.eclipse.org/bugs/buglist.cgi?product=Paho
+This project uses [Bugzilla](https://bugs.eclipse.org/bugs/buglist.cgi?product=Paho) to track ongoing development and issues.
 
 Create a new bug:
 -----------------
 
 Be sure to search for existing bugs before you create another one. Remember that contributions are always welcome!
 
-- https://bugs.eclipse.org/bugs/enter_bug.cgi?product=Paho
+- [Create new Paho bug](https://bugs.eclipse.org/bugs/enter_bug.cgi?product=Paho)

src/MQTTAsync.c

@@ -22,6 +22,7 @@
  *    Ian Craggs - MQTT 3.1.1 support
  *    Rong Xiang, Ian Craggs - C++ compatibility
  *    Ian Craggs - fix for bug 442400: reconnecting after network cable unplugged
+ *    Ian Craggs - fix for bug 444934 - incorrect free in freeCommand1
  *******************************************************************************/
 
 /**
@@ -840,21 +841,19 @@ void MQTTAsync_freeCommand1(MQTTAsync_queuedCommand *command)
 		int i;
 		
 		for (i = 0; i < command->command.details.sub.count; i++)
-		{
 			free(command->command.details.sub.topics[i]);
-			free(command->command.details.sub.topics);
-			free(command->command.details.sub.qoss);
-		}
+
+		free(command->command.details.sub.topics);
+		free(command->command.details.sub.qoss);
 	}
 	else if (command->command.type == UNSUBSCRIBE)
 	{
 		int i;
 		
 		for (i = 0; i < command->command.details.unsub.count; i++)
-		{
 			free(command->command.details.unsub.topics[i]);
-			free(command->command.details.unsub.topics);
-		}
+
+		free(command->command.details.unsub.topics);
 	}
 	else if (command->command.type == PUBLISH)
 	{