added wait() to external link creation calls + fixed new byte stream issue

portable.py

@@ -57,12 +57,12 @@ def os_link(src, dst):
       cmd = 'cmd /c mklink /D "%s" "%s"' % (dst, src)
       if IsTrace():
         Trace(cmd)
-      subprocess.Popen(cmd, stdout=subprocess.PIPE)
+      subprocess.Popen(cmd, stdout=subprocess.PIPE).wait()
     else:
       cmd = 'cmd /c mklink "%s" "%s"' % (dst, src)
       if IsTrace():
         Trace(cmd)
-      subprocess.Popen(cmd, stdout=subprocess.PIPE)
+      subprocess.Popen(cmd, stdout=subprocess.PIPE).wait()
 
 def removeReadOnlyFilesHandler(fn, path, excinfo):
     removeReadOnlyFiles(fn, path)

subcmds/upload.py

@@ -240,7 +240,7 @@ Gerrit Code Review:  http://code.google.com/p/gerrit/
              else x
              for x in script ]
 
-    script = Editor.EditString("\n".join(script)).split("\n")
+    script = portable.stream2str(Editor.EditString("\n".join(script))).split("\n")
 
     project_re = re.compile(r'^#?\s*project\s*([^\s]+)/:$')
     branch_re = re.compile(r'^\s*branch\s*([^\s(]+)\s*\(.*')